Protobuf 22.5 cpp #11961
Protobuf 22.5 cpp #11961
Conversation
…the :grpc-compiler:checkArtifacts step
…ose since it doesn't work on multiarch build arch64.
…ule instead of as a package, and this version is not available to install. Hence building cmake from source. Building the latest source of cmake needs openssl location to be specified (or have openssl turned off) so using the older version 3.13.4
…e VS 2022 installation path.
…n't show it even when it is available
…uf progress bar is causing 'access denied error' on windows console: crc-org/crc#1184
…uf progress bar is causing 'access denied error' on windows console: crc-org/crc#1184
…d cmake from source on 64 bit archs.
…ue passed to the command.
…with LIBRARY_PATH still.
…ng the CoreFoundation change for linux.
…y needed to be specified when building the exe.
|
Windows run: fusion/0b0cb5e6-81e6-47ec-982b-ea4ba8d44f23 |
buildscripts/make_dependencies.bat
Outdated
| set CMAKE_NAME=cmake-3.3.2-win32-x86 | ||
| echo on | ||
| @rem set PROTOBUF_VER=21.7 | ||
| choco install -y gradle git curl pkgconfiglite |
There was a problem hiding this comment.
We don't use the system-installed gradle, so I don't know why that is here. Git should already be installed; is this some different version of git? What uses curl?
I had thought we were going to be adding these installations to the base image itself. OpenJDK in particular I'm not wild about installed every invocation, as it is relatively large.
There was a problem hiding this comment.
Removed git and gradle. git command is not available in PATH on the VM I worked with even though the build is going through on CI.
…pportedClassVersionError after removing it: sponge2/529018d0-cbc5-4ebb-8a7f-959f90d3742d
…e build failure. Reintroducing mvn installation only in Dockerfile and not in multiarch and ubuntu.
buildscripts/make_dependencies.bat
Outdated
| set CMAKE_NAME=cmake-3.3.2-win32-x86 | ||
| choco install -y pkgconfiglite | ||
| choco install -y openjdk --version=17.0 | ||
| set JAVA_HOME="c:\Program Files\OpenJDK\jdk-17" |
There was a problem hiding this comment.
Delete JAVA_HOME. We don't want it. It just causes confusion. All tools should be able to find java from PATH.
|
The PR is for merging into master but the checks is running with 1.72.x presubmit config where I haven't changed it from windows 2016 to windows 2019. @ejona86 |
|
@kannanjgithub, it ran for both v1.72.x and master (if two kokoro jobs have the same github status name, then they overwrite each other's status). https://source.cloud.google.com/results/invocations/b798aba2-5a28-4f88-ba57-b25aa54d6e56 I'm looking into why v1.72.x is running. |
|
I don't know why v1.72.x ran. But I did re-trigger master, because your change to the machine being used hadn't propagated yet. Looks like the new run is using an upgraded machine. https://source.cloud.google.com/results/invocations/0f81ab03-5254-4051-b12f-2b3fd9b7444d |
No description provided.